Skip to content

Show an S icon for Sonarr releases with subtitles - #853

Merged
tillkruss merged 4 commits into
developfrom
feature/sonarr-subtitles-icon
Nov 4, 2026
Merged

tillkruss merged 4 commits into
developfrom
feature/sonarr-subtitles-icon

Conversation

@tillkruss

Copy link
Copy Markdown
Collaborator

Follow-up to #840. The Subtitles flag only showed in the release list as the generic flag icon, the same icon used for Scene, Internal and Double Upload. It now gets its own s.square icon, matching the existing F/P/R letter icons.

  • SeriesRelease.hasSubtitles checks for .subtitles.
  • hasOtherFlags excludes .subtitles, so a subtitles-only release shows just the S, not S plus the flag.
  • The release sheet already lists "Subtitles" by name and is unchanged. Radarr has no Subtitles flag, so movie rows are unaffected.

For comparison, Sonarr's web UI shows a single flag icon for any indexer flags and lists the names in a popover.

Verified with a macOS xcodebuild build and an iOS Simulator build, plus screenshots of the release list using fixture releases with bit 256 set.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-03T21:48:15.757848Z 6c5c972 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@tillkruss

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request

…titles-icon

# Conflicts:
#	CHANGELOG.md
#	TestFlight/WhatToTest.en-US.txt

Co-authored-by: tillkruss <665029+tillkruss@users.noreply.github.com>

Copilot AI commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Resolved the conflicts and merged develop in d17faa2. The release notes retain the S-icon wording and include the incoming develop entries.

@tillkruss

Copy link
Copy Markdown
Collaborator Author

@copilot resolve the merge conflicts in this pull request, by not changing the changelog in this PR. doesn't need a line.

Co-authored-by: tillkruss <665029+tillkruss@users.noreply.github.com>

Copilot AI commented Nov 4, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request, by not changing the changelog in this PR. doesn't need a line.

Updated in 8099fcd: the S-icon-specific wording is removed, and the changelog and TestFlight notes now match develop.

@tillkruss
tillkruss merged commit a6bed7a into develop Nov 4, 2026
5 of 7 checks passed
@tillkruss
tillkruss deleted the feature/sonarr-subtitles-icon branch November 4, 2026 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants