Repository navigation
[codex] Pin dependencies and guard copied samples - #204
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FoundationModelsKitpackage references to the currently resolved commit instead of trackingmain.FoundationModelsKitandLumoKitto their currently resolved commits.swift testand typechecks the copyableBookPlaygroundschapter snippets.GenerationOptions(sampling:)label.Notes
The remaining
branch: mainentries in the XcodePackage.resolvedfile are transitive requirements from theLumoKitdependency graph (swift-embeddingsandVecturaKit). I left those alone because hand-editing generated lockfile state would be reverted by Xcode resolution unless the upstream manifests change or this repo takes explicit ownership of those transitive pins.Verification
swift testbash Tools/BookPlaygrounds/typecheck.shxcodebuild -quiet -project FoundationLab.xcodeproj -scheme 'Foundation Lab' -destination 'generic/platform=macOS' CODE_SIGNING_ALLOWED=NO buildgit diff --check