test: cover public protocol boundary limits - #7
Conversation
Signed-off-by: Sebastian Legarraga <64795732+slegarraga@users.noreply.github.com>
rufatixx
left a comment
There was a problem hiding this comment.
Thanks for the focused, test-only contribution. I verified that the current patch is safe to run, and CI is green on the repository-pinned .NET 10.0.201 SDK (37/37 tests, simulator, dependency audit, and package build all pass).
Before merging, please complete the inbound-validation part of #2. Most current boundary assertions exercise only RelayIdentity or RelayCryptography.Encrypt; RelayPacketValidator is reached through Decrypt only for oversized ciphertext.
Please extend the tests so a valid packet is also accepted through Decrypt at the maximum payload, node-ID, content-type, and TTL boundaries, and so mutated inbound packets are rejected for the listed invalid/empty node-ID, content-type, and TTL cases (including both sender and recipient identifiers where applicable). Keep the tests deterministic and test-only.
Once those public ingress paths are covered and CI remains green, #2 will be fully satisfied and this will be ready to merge.
Signed-off-by: Sebastian Legarraga <64795732+slegarraga@users.noreply.github.com>
|
Thanks for the detailed review. I extended the test suite so inbound packets are exercised through |
What & why
Adds deterministic boundary tests for the public protocol limits and validation paths: payload size, node ID length, content type length, TTL, empty identifiers, and ciphertext validation through decryption.
Closes #2.
Coverage
Verification
dotnet test tests/RelayOS.Core.Tests: 37 tests pass.global.json; I temporarily bypassed the pin for local verification and did not modify or includeglobal.json.