Directly download applications.menu from KDE GitLab#5
Open
MattiDragon wants to merge 2 commits into
Open
Conversation
Make it so that the applications.menu file is directly downloaded from GitLab. This is necessary in order to work around the QT5 version of kservice being removed from nixpkgs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latest nixpkgs broke this overlay because
libsForQt5.kservicewas removed. The QT 6 version doesn't have the menu file. This PR adds in a derivation that downloads the file from the KDE GitLab and places it in the expected location.I also updated the nixpkgs version in order to make this actually matter without overriding it in your own flake.