ops(security): scan main on push too, so post-fix scans clear stale alerts#148
Merged
Conversation
…lerts Trivy alerts on the main-branch alert track only auto-close when a SARIF scan publishes against refs/heads/main with the same (workflow, job, category) tuple. Currently pr-container-scan.yml only triggers on pull_request, so scans always upload against PR refs — main-track alerts go stale after every fix merge. Concrete impact: cycles-server-events had 13 stale gnutls alerts after PR #54 (the gnutls fix) merged. Required a no-op Dockerfile-comment PR (#57) to retrigger the scan and finally clear them. Fix: add 'push: branches: [main]' trigger with the same paths filter. Now every fix-merge to main re-scans and updates the alert track. Side effect: image tag template changed from 'pr-N' to 'scan-{N or sha}' so it's defined for both event types. Image is local-only (load:true, push:false) so the tag value doesn't matter to anything downstream.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
push: branches: [main]trigger to pr-container-scan.yml so Trivy re-scans after every fix merge — closing the stale-alerts gap that required PR #57 to manually nudge events.Same change applied across cycles-server-admin, cycles-server-events, cycles-dashboard for consistency.