fix(ci): no-cache + pull on container scan#149
Merged
Conversation
Same fix as cycles-dashboard PR #158. Caching the apk upgrade layer makes Trivy scan a cached image rather than what would actually be built today. For security scans we always want the fresh state. Tradeoff: ~3-5 min scan instead of ~30s. Right tradeoff for security-scan workflows.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same fix as cycles-dashboard#158. Cached
apk upgradelayers make Trivy scan stale package state.no-cache: true+pull: trueensures every scan runs against what would actually be built today. ~3-5 min scan instead of ~30s — correct tradeoff for security.