Skip to content

Conversation

@NocturneCC
Copy link

Overview

Adds Events Made Easy, a RuneLite plugin for community-run OSRS events such as bingo, tile boards, and team-based challenges.

The plugin allows event organizers to configure events externally while providing players with:

  • In-game event boards
  • Live drop detection
  • Automatic board refresh
  • Optional Discord webhook posting

Backend / Networking

  • Uses a hosted HTTPS backend (https://registry.events-made-easy.app)
  • No credentials stored on disk
  • No IP addresses, API keys, or secrets embedded in the plugin

Data & Privacy

  • Sends only: event code, player name, item ID/name, quantity, and source
  • No account identifiers, hashes, or personal data
  • Backend endpoints are fixed and not user-configurable

Plugin Hub Compliance

  • No external libraries added
  • Limited defensive reflection for optional API compatibility (no internal access)
  • No dynamic code loading
  • No arbitrary file system access (only bundled resources and RuneLite config storage)
  • Network access is limited to a fixed HTTPS registry endpoint
  • Admin passwords are never stored (refers to admin passwords to configure created events)

Notes for Reviewers

  • Health and registry endpoints are validated at runtime
  • Auto-join uses locally stored event codes only when enabled
  • All remote calls fail safely if the backend is unavailable

Happy to address any review feedback or requested changes.

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 16, 2025

@runelite-github-app
Copy link

runelite-github-app bot commented Dec 16, 2025

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@LlemonDuck
Copy link
Contributor

don't make new prs, just edit your existing ones

@NocturneCC
Copy link
Author

Sorry about that! I am really new at this. Should I just remove all the extra files I added and put in the correct plugins/ file?

@NocturneCC
Copy link
Author

closed the duplicate request and modified this one until successful build

@riktenx
Copy link
Member

riktenx commented Dec 21, 2025

the only file you should be changing (adding in this case) is your hub manifest file. you've somehow edited the .gitignore. undo those changes, this submission is not valid until you do

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 21, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 21, 2025
@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 21, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 21, 2025
@NocturneCC
Copy link
Author

unified the .gitignore

@riktenx
Copy link
Member

riktenx commented Dec 26, 2025

We don't allow reflection in hub plugins: https://github.com/NocturneCC/events-made-easy/blob/a73d198a7ad03c263782cab384d77c774d43a1ab/src/main/java/cc/nocturne/eventsmadeeasy/EventsPlugin.java#L415. It looks like you fixed this in your master branch but you need to update the commit hash in your marker file here.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 26, 2025
@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 26, 2025
@NocturneCC
Copy link
Author

updated commitment to show removed reflection

@riktenx
Copy link
Member

riktenx commented Dec 28, 2025

Please don't spawn threads willynilly every time you make a new network request. Either create and use an Executor (e.g. Executors.newSingleThreadedExecutor()) or use OkHttp's newCall().enqueue().

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin added size-0 waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants