-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add Events Made Easy plugin #9870
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
New plugin |
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
don't make new prs, just edit your existing ones |
|
Sorry about that! I am really new at this. Should I just remove all the extra files I added and put in the correct plugins/ file? |
cf020e7 to
d1520c0
Compare
|
closed the duplicate request and modified this one until successful build |
|
the only file you should be changing (adding in this case) is your hub manifest file. you've somehow edited the .gitignore. undo those changes, this submission is not valid until you do |
dcc29ae to
e31ed69
Compare
|
unified the .gitignore |
|
We don't allow reflection in hub plugins: https://github.com/NocturneCC/events-made-easy/blob/a73d198a7ad03c263782cab384d77c774d43a1ab/src/main/java/cc/nocturne/eventsmadeeasy/EventsPlugin.java#L415. It looks like you fixed this in your master branch but you need to update the commit hash in your marker file here. |
|
updated commitment to show removed reflection |
|
Please don't spawn threads willynilly every time you make a new network request. Either create and use an Executor (e.g. Executors.newSingleThreadedExecutor()) or use OkHttp's newCall().enqueue(). |
Overview
Adds Events Made Easy, a RuneLite plugin for community-run OSRS events such as bingo, tile boards, and team-based challenges.
The plugin allows event organizers to configure events externally while providing players with:
Backend / Networking
https://registry.events-made-easy.app)Data & Privacy
Plugin Hub Compliance
Notes for Reviewers
Happy to address any review feedback or requested changes.