Added Offer at Price plugin

[asundr]

This plugin gives players the option to match offered items in a player trade with coins (or vice versa) by entering a price per item rather than a quantity.

To use this, players must shift-right click the item they intend to give and select the "Offer price X " option. Visually, this replaces the "Offer-X" option (only for shift clicks) since it actually just renames and adds functionality to this existing option.

The option is only available if the other player has submitted their offer and that offer has only a single type of item. The plugin currently only supports trades involving currency for items.

[runelite-github-app]

New plugin offer-at-price: https://github.com/asundr/runelite-offer-at-price/tree/6b2fab85d16a6b453cc2c1cd3b73cf37c7f5fab5

[runelite-github-app]

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.

---

Internal use only: Reviewer details Maintainer details

[riktenx]

I've given this some thought and unfortunately I think this constitutes autotyping. You are modifying the input of a chat prompt programmatically. This is explicitly rejected for the chatbox and I do not see why this wouldn't count as the chatbox. https://github.com/runelite/runelite/wiki/Rejected-or-Rolled-Back-Features

Prompting the user and then showing the offer-x number for them to type should be fine.

[asundr]

Thanks for the feedback! I understand if you'd prefer not to include the plugin in it's current state.

You've probably considered these points but I figured I'd share some of my thinking around this:

• There are other approved plugins that do very similar things within the same text entry panel such as converting decimals of K/M/B to their integer equivalent, and others (like GE Calc) that programmatically evaluates arithmetic expressions into their resulting value. Presumably this is because the input serves as a prompt to submit numeric values and not for chatting purposes?
• Players still need to manually enter a value that may sometimes require more characters than simply entering a quantity
• This is a feature that allows players to trade at prices that both players have already agreed to and doesn't really give the player using the plugin a game advantage. My feeling is that giving players a way to avoid calculation errors and ensure that agreed to prices are actually met is more in the spirit of the game.

Anyway, that's my 2 cents on the matter. I appreciate your suggestion, but I think the plugin would end up being little more useful than just using a calculator at that point and I'd probably want to approach it quite differently given that restriction.

In any case, even if you still think the plugin is inappropriate thanks for taking the time to consider it.

[riktenx]

dynamic register/unregister can get kind of flaky and makes you liable to leak registrations which can cause client stability issues. typically you should always statically add/remove on startup/shutdown and then just defer to a bool flag or something to know when a listener should do work

[asundr]

Ah good to know. I've replaced the dynamic register/unregister calls with setting a bool. I also included a few changes to the plugin behaviour to better match offers and to notify the player if the plugin is unable to match a trade at the entered price.