Skip to content

Conversation

@adnapPanda
Copy link
Contributor

Created a plugin that tracks the amount of stalls thieved during a session.
Also tracks the pet chance based on the stalls thieved.
Data is saved between sessions.

@runelite-github-app
Copy link

@runelite-github-app
Copy link

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx
Copy link
Member

riktenx commented Dec 27, 2025

Why are you saving state to disk? Just use the rsprofile methods on config manager e.g. https://static.runelite.net/runelite-client/apidocs/net/runelite/client/config/ConfigManager.html#getRSProfileConfiguration(java.lang.String,java.lang.String), that'll make this a lot easier to review. Doing file operations requires much more scrutiny from the reviewer.

This is ultimately optional but I'm going to give you a chance to do it before I review this further. If you don't want to make the switch, or I don't receive a response for 30 days, I'll review this as-is.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 27, 2025
@adnapPanda
Copy link
Contributor Author

adnapPanda commented Dec 27, 2025 via email

@runelite-github-app runelite-github-app bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Dec 27, 2025
@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Dec 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin added size-0 waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants