fix(handler): return error response when SGLang requests fail with non-200 status#32
Open
sainarne15 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
async_handlerhas three request paths (explicit OpenAI route, chat/completionsshorthand, and native
/generate). Case 3 guards against non-200 responses beforeyielding; Cases 1 and 2 do not, passing whatever SGLang returns directly into
process_responseoriter_lines.In failure scenarios — misconfigured
MODEL_NAME, OOM crashes, unsupportedparameters — this causes SGLang's error payload to be streamed back as valid
response chunks. The caller receives no
errorkey and no status indication,making the failure mode indistinguishable from legitimate model output at the
application layer.
Changes
Added the same
status_codeguard to Cases 1 and 2 that Case 3 already employs.Error messages are intentionally scoped per route (
"Request failed..."for OpenAIroutes vs
"Generate request failed..."for/generate) to preserve endpointcontext in the error response.
Testing
docker build --platform linux/amd64 -t worker-sglang-test .passespayload is surfaced as model output without the guard, and correctly returned
as a structured error with it