Skip to content

tests(process): fix failing test_write_and_read_pid_file on macOS #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ADD-SP merged 1 commit into from
Feb 15, 2026
Merged

tests(process): fix failing test_write_and_read_pid_file on macOS #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 14 additions & 6 deletions src/process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,12 +221,20 @@ mod tests {

#[test]
fn test_write_and_read_pid_file() {
// Ensure the PID directory exists (may need permissions)
if let Some(parent) = pid_file_path().parent()
&& fs::create_dir_all(parent).is_err()
{
eprintln!("Skipping test_write_and_read_pid_file: cannot create PID dir");
return;
let pid_path = pid_file_path();
// Ensure the PID directory exists and is writable
if let Some(parent) = pid_path.parent() {
if fs::create_dir_all(parent).is_err() {
eprintln!("Skipping test_write_and_read_pid_file: cannot create PID dir");
return;
}
// Check we can actually write in this directory
let probe = parent.join(".clawshell_write_probe");
if fs::write(&probe, b"").is_err() {
eprintln!("Skipping test_write_and_read_pid_file: PID dir not writable");
return;
}
let _ = fs::remove_file(&probe);
}
let test_pid = process::id();
write_pid_file(test_pid).unwrap();
Expand Down