Skip to content

fix: fraction condition.#8

Open
VanhGer wants to merge 2 commits into
rust-crypto-labs:masterfrom
VanhGer:fix/fraction
Open

fix: fraction condition.#8
VanhGer wants to merge 2 commits into
rust-crypto-labs:masterfrom
VanhGer:fix/fraction

Conversation

@VanhGer
Copy link
Copy Markdown

@VanhGer VanhGer commented Oct 13, 2025

This PR fixes the issue that we cant compare directly Rational with (u16, u16) in src/algebra/scalar.rs:112

@enizor
Copy link
Copy Markdown

enizor commented Oct 13, 2025

Using a MiniRational (requiring rug >=1.23.0) would avoid an allocation.

@VanhGer
Copy link
Copy Markdown
Author

VanhGer commented Oct 13, 2025

Using a MiniRational (requiring rug >=1.23.0) would avoid an allocation.

Sure. I updated the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants