Conversation
xd009642
requested changes
Jul 22, 2025
Member
xd009642
left a comment
xd009642
left a comment
There was a problem hiding this comment.
LGTM, but could you just run cargo fmt and push the changes so CI can be green
xd009642
approved these changes
Jul 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Necessary changes to use the latest version of the
imagecrate.Upgraded all usages of the
imagecrate to version0.25.Upgraded all usages of the
imageproccrate to version0.25.Upgraded the
nsharecrate to version0.10.Upgraded the
ndarraycrate to version0.16.I'm not sure if replacing
castwith.value_into().unwrap()is ok.ndarray'sinto_raw_vecwas deprecated. The recommended replacement isinto_raw_vec_and_offset. Didn't replace it in this PR because I am not sure if the offset has to be handled in some way.