Skip to content

Conversation

@kisum9
Copy link
Contributor

@kisum9 kisum9 commented Oct 9, 2025

Add definitions for the HCR_EL2.TVM and HCR_EL2.VSE fields, corresponding to bit [26] ("TVM") and bit [8] ("VSE") as defined in the Arm Architecture Reference Manual.

@jonathanpallant
Copy link

Please check the rendered output from running cargo doc. You have some bullet lists without bullets that I believe will render poorly.

@kisum9 kisum9 force-pushed the add-field-to-hcr_el2 branch from 27a1a3e to df2b0ad Compare October 9, 2025 11:33
@kisum9
Copy link
Contributor Author

kisum9 commented Oct 9, 2025

Please check the rendered output from running cargo doc. You have some bullet lists without bullets that I believe will render poorly.

Thanks for pointing that out! I've fixed the issues you mentioned and updated the PR. Please take another look when you have time.

@berkus
Copy link
Member

berkus commented Oct 12, 2025

image

There are still some broken doc lines in the crate level documentation. I assume the other PRs also have similar issues?

Copy link
Member

@berkus berkus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix them.

@kisum9
Copy link
Contributor Author

kisum9 commented Oct 13, 2025

Please fix them.

It seems this is a pre-existing issue. Would you prefer I fix all the HCR_EL2 broken doc lines in this PR?

@kisum9
Copy link
Contributor Author

kisum9 commented Oct 13, 2025

image image image and others

@berkus
Copy link
Member

berkus commented Oct 14, 2025

Yep, just moving them apart from the first line should fix the issue.

VSE, TVM

Signed-off-by: Yan Tan <tanyan@kylinos.cn>
@kisum9 kisum9 force-pushed the add-field-to-hcr_el2 branch from df2b0ad to 2fb4f2d Compare October 17, 2025 09:08
@kisum9
Copy link
Contributor Author

kisum9 commented Oct 17, 2025

Yep, just moving them apart from the first line should fix the issue.

I’ve fixed the issue. take another look when you have time, thanks ^^

@berkus
Copy link
Member

berkus commented Oct 19, 2025

I’ve fixed the issue. take another look when you have time, thanks ^^

Thank you!

@berkus berkus merged commit 16a3c76 into rust-embedded:main Oct 19, 2025
15 checks passed
@github-actions github-actions bot mentioned this pull request Oct 19, 2025
@kisum9 kisum9 deleted the add-field-to-hcr_el2 branch October 21, 2025 07:08
@kisum9
Copy link
Contributor Author

kisum9 commented Oct 21, 2025

Happy to help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants