Merged
Conversation
jackh726
approved these changes
Nov 7, 2020
Member
jackh726
left a comment
jackh726
left a comment
There was a problem hiding this comment.
LGTM. Gonna hold off on merging until rustc side is merged. But once that happens, anyone should feel free to merge.
LeSeulArtichaut
force-pushed
the
visitor-breakty
branch
from
d6e34a4 to
905c72d
Compare
Contributor
Author
|
Status: rust-lang/compiler-team#383 should finish its FCP in two hours and rust-lang/rust#78779 was just |
Member
|
Works for me! @bors r+ |
Contributor
|
📌 Commit 905c72d has been approved by |
Contributor
Contributor
|
☀️ Test successful - checks-actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the equivalent of MCP rust-lang/compiler-team#383 in chalk.
r? @jackh726
Should probably be blocked on rust-lang/compiler-team#383.