add lib.miri.rs file for miri-test-libstd#586
Merged
Amanieu merged 1 commit intorust-lang:masterfrom Apr 10, 2024
Merged
Conversation
Member
Author
|
What I am not sure about is whether this file will be picked up by cargo when creating the package for crates.io. |
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Apr 10, 2024
MIRI_REPLACE_LIBRS_IF_NOT_TEST: also apply to crates.io crates This is needed to make rust-lang/compiler-builtins#586 work.
Member
Yes, it was picked up by Cargo. |
Member
Author
|
Awesome, thanks for checking. :) |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Apr 13, 2024
MIRI_REPLACE_LIBRS_IF_NOT_TEST: also apply to crates.io crates This is needed to make rust-lang/compiler-builtins#586 work.
tgross35
pushed a commit
that referenced
this pull request
Jan 31, 2026
add lib.miri.rs file for miri-test-libstd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In rust-lang/rust#123317 we added
lib.miri.rsfiles for core, alloc, and std to enablecargo miri teston those crates. Bootstrap has a comment that explains what this is about:compiler_builtins has the same issue -- it defines global symbols via
extern "C" fn, and then Miri complains that the same function is defined multiple times and calls to that function elsewhere are ambiguous.This can be fixed by adding a lib.miri.rs here as well.
Fixes rust-lang/miri-test-libstd#59