Display crates.io search errors instead of logging them#2751
Closed
byfnoel wants to merge 4 commits intorust-lang:masterfrom
Closed
Display crates.io search errors instead of logging them#2751byfnoel wants to merge 4 commits intorust-lang:masterfrom
byfnoel wants to merge 4 commits intorust-lang:masterfrom
Conversation
When queries to `crates.io` API return errors, we will display them instead of logging them as errors. Closes rust-lang#2480
github-actions
bot
added
the
S-waiting-on-review
Member
|
Do you have a screenshot of the result? Like this, it's a bit difficult to see what it changes. |
Contributor
Author
|
Closing this pr because this other pr has better chance of merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When queries to
crates.ioAPI return errors, we will display them instead of logging them as errors.Closes #2480