Skip to content

Conversation

@syphar
Copy link
Member

@syphar syphar commented Feb 5, 2026

We have two main kinds of build-errors:

  1. "standard" rustc build errors, which always ended up in the proper tables
  2. "errors before the build even starts" (like, a broken cargo.toml file, fails when fetching dependencies).

Since we also add in-progress builds to the database, we can see both error types in the proper interfaces.

But (My guess) from the times before that, we wanted some record of the failed build. And these were these queue entries where we tried more than X times.

This leads to around ~5k entries in the queue table of old failed builds.

I don't think we need these any more and can keep a clean queue table without any issues.

I also fixed my TestMetrics / CollectedMetrics testing stub, which returned the wrong values when we queried the values multiple times.

@syphar syphar self-assigned this Feb 5, 2026
@syphar syphar requested a review from a team as a code owner February 5, 2026 06:55
@github-actions github-actions bot added the S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed label Feb 5, 2026
@syphar syphar force-pushed the build-queue-latest branch from 0ac9057 to 6b51d4c Compare February 5, 2026 07:04
@syphar syphar marked this pull request as draft February 5, 2026 07:23
@syphar

This comment was marked as outdated.

@syphar syphar force-pushed the build-queue-latest branch from 6b51d4c to c788658 Compare February 5, 2026 15:13
@syphar syphar marked this pull request as ready for review February 5, 2026 15:31
@syphar
Copy link
Member Author

syphar commented Feb 5, 2026

@GuillaumeGomez ready for review now

@GuillaumeGomez
Copy link
Member

Looks good to me, thanks!

@GuillaumeGomez GuillaumeGomez merged commit ebaa079 into rust-lang:main Feb 5, 2026
13 checks passed
@GuillaumeGomez GuillaumeGomez deleted the build-queue-latest branch February 5, 2026 16:17
@github-actions github-actions bot added S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it and removed S-waiting-on-review Status: This pull request has been implemented and needs to be reviewed labels Feb 5, 2026
@syphar syphar removed the S-waiting-on-deploy This PR is ready to be merged, but is waiting for an admin to have time to deploy it label Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants