Don't keep old failed builds in the build queue #3178
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have two main kinds of build-errors:
Since we also add in-progress builds to the database, we can see both error types in the proper interfaces.
But (My guess) from the times before that, we wanted some record of the failed build. And these were these queue entries where we tried more than X times.
This leads to around ~5k entries in the queue table of old failed builds.
I don't think we need these any more and can keep a clean queue table without any issues.
I also fixed my
TestMetrics/CollectedMetricstesting stub, which returned the wrong values when we queried the values multiple times.