repr(packed) can take arguments #636
Conversation
src/attributes.rst
Outdated
|
|
||
| AlignmentDecrease ::= | ||
| $$packed$$ | ||
| $$packed$$ $$($$ DecimalLiteral $$)$$? |
There was a problem hiding this comment.
Unfortunately the grammar is not correct. As currently formulated, only the closing parenthesis is optional. You will need to introduce an intermediate production:
$$packed$$ XXX?
XXX ::=
$$($$ DecimalLiteral $$)$$
Unfortunately I cannot come up with a good name for XXX. PackedValue, AlignmentValue, something else.
I am not sure why attribute repr lacks more legality rules, but I think we should at least consider adding a few rules for this text and this text.
There was a problem hiding this comment.
would using a bracket work, like $$packed$$ ($$($$ DecimalLiteral $$)$$)?
There was a problem hiding this comment.
I considered that, but I found the mix of grouping parentheses and syntactic parentheses a bit confusing. Note that you may also consider the following refactor:
AlignmentDecrease ::=
packed AlignmentValue?
AlignmentIncrease ::=
align AlignmentValue
AlignmentValue ::=
$$($$ DecimalLiteral $$)$$
tshepang
force-pushed
the
tshepang/packed-takes-an-arg
branch
from
73726c6 to
a67ffe5
Compare
2 participants
No description provided.