Skip to content

Conversation

@shuoli84
Copy link

fix #315

@Amanieu
Copy link
Member

Amanieu commented Mar 22, 2022

I don't think prepare_resize is the issue here since it is only called from one place (resize_inner). Perhaps the #[inline(always)] should be removed from resize_inner instead?

@shuoli84
Copy link
Author

I don't think prepare_resize is the issue here since it is only called from one place (resize_inner). Perhaps the #[inline(always)] should be removed from resize_inner instead?

Yes, I think so, resize_inner is the better place to do the modify. Thx.

@bors
Copy link
Contributor

bors commented Sep 5, 2023

☔ The latest upstream changes (presumably #468) made this pull request unmergeable. Please resolve the merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

hide inline attribute for prepare_resize behind inline_more

3 participants