Conversation
RalfJung
reviewed
Dec 13, 2019
RalfJung
reviewed
Dec 13, 2019
Contributor
|
☔ The latest upstream changes (presumably #1118) made this pull request unmergeable. Please resolve the merge conflicts. |
Member
|
@oli-obk what is the plan with this one? |
Contributor
Author
|
yea but there's no way to do this by landing something here first. We'll still get the breakage from the rustc PR so we may as well wait for the merger. I'll update this PR though to make all the changes so we can land it immediately |
oli-obk
force-pushed
the
to_ptr_considered_harmful
branch
from
ceaab16 to
4aef81e
Compare
Contributor
Author
|
@bors r+ |
Contributor
|
📌 Commit 4aef81e has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Dec 27, 2019
Remove all uses of `to_ptr` Also only works on top of rust-lang/rust#67192
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also only works on top of rust-lang/rust#67192