Merged
Conversation
Contributor
|
@bors r+ |
Contributor
|
📌 Commit 959033c has been approved by |
Contributor
bors
added a commit
that referenced
this pull request
Jan 2, 2020
…king, r=oli-obk Bump rustc version to fix miri Fixes rust-lang/rust#67793
Contributor
|
☀️ Test successful - checks-travis, status-appveyor |
RalfJung
reviewed
Jan 2, 2020
| @@ -1,3 +1,5 @@ | |||
| #![allow(const_err)] // don't warn about truncating casts | |||
Member
There was a problem hiding this comment.
Wait, so hard errors inside constants and const-prop-originating warnings outside constants use the same lint name? Isn't that odd?
Member
There was a problem hiding this comment.
Ah no, turns out rust-lang/rust#67676 made these overflows err-by-default, actually. Interesting.
Member
There was a problem hiding this comment.
But to me the lint looks wrong here:
enum Signed {
Bar = -42,
Baz,
Quux = 100,
}
fn signed() -> [i8; 3] {
let baz = Signed::Baz; // let-expansion changes the MIR significantly
[Signed::Bar as i8, baz as i8, Signed::Quux as i8]
}Signed::Bar is -42 which is well inside the range of i8. So why is there an error shown?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rust-lang/rust#67793