-
Notifications
You must be signed in to change notification settings - Fork 314
Update ownership.md for clarity #428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gdennie
wants to merge
1
commit into
rust-lang:master
Choose a base branch
from
gdennie:patch-1
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
|
|
@@ -41,9 +41,9 @@ be forced to accept your program on the assumption that it is correct. | |||||||
| This will never happen to Rust. It's up to the programmer to prove to the | ||||||||
| compiler that everything is sound. | ||||||||
|
|
||||||||
| Of course, Rust's story around ownership is much more complicated than just | ||||||||
| verifying that references don't escape the scope of their referent. That's | ||||||||
| because ensuring pointers are always valid is much more complicated than this. | ||||||||
| Of course, Rust's story around ownership is much more complicated than simply | ||||||||
| gauranteeing that references cannot outlive their target. That is | ||||||||
| because ensuring pointers are always valid in the general case is much more complicated. | ||||||||
| For instance in this code, | ||||||||
|
|
||||||||
| ```rust,compile_fail | ||||||||
|
|
@@ -59,7 +59,10 @@ data.push(4); | |||||||
| println!("{}", x); | ||||||||
| ``` | ||||||||
|
|
||||||||
| naive scope analysis would be insufficient to prevent this bug, because `data` | ||||||||
| does in fact live as long as we needed. However it was *changed* while we had | ||||||||
| a reference into it. This is why Rust requires any references to freeze the | ||||||||
| referent and its owners. | ||||||||
| a naive scope analysis would be insufficient to prevent this bug because `data` | ||||||||
| does indeed live as long as required. However, `data` is *changed* by `push(4)` | ||||||||
| and now may have been realocated to accommodate the new value. | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||
| Consequently, `x` may now be referring to the old | ||||||||
| value or memory already put to use in another process (pre-emptive multi-tasking). | ||||||||
|
Comment on lines
+65
to
+66
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Going into detail this far (another process & preemptive multitasking) is misleading in multiple ways:
Suggested change
|
||||||||
| This is why Rust requires the code to also treat the target as frozen; and so, | ||||||||
| will refuse the expression, `data.push(4)`. | ||||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.