Ignore span's parents in collect_ast_format_args/find_format_args#11473
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 12, 2023
Merged
Ignore span's parents in collect_ast_format_args/find_format_args#11473bors merged 1 commit intorust-lang:masterfrom
collect_ast_format_args/find_format_args#11473bors merged 1 commit intorust-lang:masterfrom
Conversation
rustbot
added
the
S-waiting-on-review
Alexendoo
added
the
beta-nominated
Member
Author
|
Beta nominating this because incremental relative spans will be enabled by default in stable 1.74 rust-lang/rust#115656, if it would get into 1.74 without backporting it can be left out |
dswij
approved these changes
Sep 12, 2023
Member
|
Thank you! @bors r+ |
Contributor
Contributor
Contributor
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
flip1995
removed
the
beta-nominated
Member
|
This already made it into the current nightly ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #11470, covers some cases missed by #10980
Can't have a test yet because of #11126 but it works locally
changelog: none
r? @dswij