Add CI step to prevent new untranslatable diagnostics being added

[clubby789]

This is in order to prevent new untranslatable diagnostics from being added, as this requires additional work to migrate them later on.

[rustbot]

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

[rustbot]

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

[clubby789]

Ideally this would also work with x run/x test but we can't recursively invoke x because of the file locking

[clubby789]

Hmm, this doesn't seem to work right now. I'm guessing the first set of warnings hit deny-warnings and stop the build?

@rustbot author

[clubby789]

@rustbot ready

[Mark-Simulacrum]

I'm not a fan of this approach. I think it would be better to start with adding allow's to all crates/modules that have this problem and then gradually remove those when we're ready with that crate.

r? @davidtwco

[bors]

☔ The latest upstream changes (presumably #110152) made this pull request unmergeable. Please resolve the merge conflicts.

[clubby789]

I'm a bit worried that moving to allows will make it harder to differentiate between "Hasn't been looked at yet" and "Too complex to migrate right now"/"Cannot be migrate". A comment on each allow might help, but right now there's around 900 remaining diagnostics across around 100 files

[davidtwco]

I'm a bit worried that moving to allows will make it harder to differentiate between "Hasn't been looked at yet" and "Too complex to migrate right now"/"Cannot be migrate". A comment on each allow might help, but right now there's around 900 remaining diagnostics across around 100 files

Apologies for the delay in replying here, but I think I agree with @Mark-Simulacrum that adding allows would be a slightly nicer approach, requiring less new machinery. It's a little bit more up-front work if we wanted to add comments to everything, but we could start with a coarser approach of just adding #[allow] on modules.

[JohnCSimon]

@clubby789
ping from triage - can you post your status on this PR? There hasn't been an update in a few months. Thanks!

[clubby789]

Sorry, missed the ping. Closing now in favour of #120693