reduce deps for windows-msvc targets for backtrace

[klensy]

(eventually) mirrors rust-lang/backtrace-rs#543

Some dependencies of backtrace don't used on windows-msvc targets, so exclude them:

miniz_oxide (+ adler)
addr2line (+ gimli)
object (+ memchr)

This saves about 30kb of std.dll + 17.5mb of rlibs

[rustbot]

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

[bors]

☔ The latest upstream changes (presumably #108485) made this pull request unmergeable. Please resolve the merge conflicts.

[klensy]

@rustbot ready this eventually be reviewed in backtrace-rs repo, but let's not block on it

[klensy]

Let's reroll r?

[rustbot]

Error: Parsing assign command in comment failed: ...'' | error: specify user to assign to at >| ''...

Please file an issue on GitHub at triagebot if there's a problem with this bot, or reach out on #t-infra on Zulip.

[ChrisDenton]

Why was public = false removed?

[klensy]

I don't remember why ;-)
https://rust-lang.github.io/rfcs/1977-public-private-dependencies.html

Q: Where is public / private defined?
Dependencies are private by default and are made public through a public flag on the dependency in the Cargo.toml file. This also means that crates created before the implementation of this RFC will have all their dependencies private.

Probably some unintentional change, but it shouldn't affect anything, as by default it public = false. I can try revert this?

[ChrisDenton]

If it makes no difference then it's fine. But if so then I'm curious why it was added in the first place.

[ChrisDenton]

This looks great to me! I'm still a bit curious about the public=false thing but I don't see that as a reason to block this PR, which has been around awhile already.

@bors r+

[bors]

📌 Commit 8238361 has been approved by ChrisDenton

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8238361 with merge 08691f0...

[bors]

☀️ Test successful - checks-actions
Approved by: ChrisDenton
Pushing 08691f0 to master...

[rust-timer]

Finished benchmarking commit (08691f0): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.6%, 0.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.3%]	1
Improvements ✅ (secondary)	-1.4%	[-1.4%, -1.4%]	1
All ❌✅ (primary)	-2.3%	[-2.3%, -2.3%]	1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 632.73s -> 632.877s (0.02%)