Disabled socketpair for Vita#115816
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 13, 2023
vita-rust:vita
Merged
Conversation
Collaborator
|
r? @cuviper (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
O-unix
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#115736 (Remove `verbose_generic_activity_with_arg`) - rust-lang#115771 (cleanup leftovers of const_err lint) - rust-lang#115798 (add helper method for finding the one non-1-ZST field) - rust-lang#115812 (Merge settings.css into rustdoc.css) - rust-lang#115815 (fix: return early when has tainted in mir pass) - rust-lang#115816 (Disabled socketpair for Vita) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2023
Rollup merge of rust-lang#115816 - vita-rust:vita, r=cuviper Disabled socketpair for Vita There is no `socketpair` syscall in Vita newlib. This is reflected in a rust-lang/libc#3284, in which this method is removed for vita target. Also, we would need the fixes from the abovementioned PR for sockets in std (previously we had some incorrect constant values), but that can be done separately when rust-lang/libc#3284 is reviewed, merged, and released.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no
socketpairsyscall in Vita newlib. This is reflected in a rust-lang/libc#3284, in which this method is removed for vita target.Also, we would need the fixes from the abovementioned PR for sockets in std (previously we had some incorrect constant values), but that can be done separately when rust-lang/libc#3284 is reviewed, merged, and released.