refactor infer var storage

[lcnr]

cleanup the code, discovered while working on #118725

[rustbot]

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

[lcnr]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 9297826 with merge bc279f6...

[bors]

☀️ Try build successful - checks-actions
Build commit: bc279f6 (bc279f6c01306ace3aec92603ed3cbfb219eb41a)

[rust-timer]

Finished benchmarking commit (bc279f6): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.3%	[-0.4%, -0.2%]	2
Improvements ✅ (secondary)	-0.3%	[-0.4%, -0.2%]	11
All ❌✅ (primary)	-0.3%	[-0.4%, -0.2%]	2

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.1%	[1.3%, 2.9%]	2
Regressions ❌ (secondary)	2.5%	[0.6%, 4.2%]	5
Improvements ✅ (primary)	-1.6%	[-2.1%, -0.8%]	3
Improvements ✅ (secondary)	-2.4%	[-2.4%, -2.4%]	1
All ❌✅ (primary)	-0.1%	[-2.1%, 2.9%]	5

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.1%	[-1.5%, -0.7%]	2
Improvements ✅ (secondary)	-2.4%	[-2.8%, -1.8%]	7
All ❌✅ (primary)	-1.1%	[-1.5%, -0.7%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.729s -> 674.036s (-0.10%)
Artifact size: 314.07 MiB -> 314.00 MiB (-0.02%)

[compiler-errors]

uwu
r? compiler-errors @bors r+ rollup=never

[bors]

📌 Commit 9297826 has been approved by compiler-errors

It is now in the queue for this repository.

[bors]

⌛ Testing commit 9297826 with merge 5f5d248...

[bors]

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 5f5d248 to master...

[rust-timer]

Finished benchmarking commit (5f5d248): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.2%]	6
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.9%	[2.9%, 2.9%]	1
Regressions ❌ (secondary)	0.8%	[0.8%, 0.8%]	1
Improvements ✅ (primary)	-1.8%	[-1.8%, -1.8%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[-1.8%, 2.9%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.1%	[1.1%, 1.1%]	1
Regressions ❌ (secondary)	2.4%	[1.8%, 2.8%]	3
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.8%	[-5.3%, -3.8%]	3
All ❌✅ (primary)	1.1%	[1.1%, 1.1%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 672.519s -> 671.948s (-0.08%)
Artifact size: 312.30 MiB -> 312.30 MiB (-0.00%)