tests/codegen/asm: Remove uses of rustc_attrs and lang_items features by using minicore#134562
Merged
bors merged 1 commit intorust-lang:masterfrom Dec 20, 2024
Merged
Conversation
… by using minicore
rustbot
added
S-waiting-on-review
jieyouxu
approved these changes
Dec 20, 2024
Member
jieyouxu
left a comment
jieyouxu
left a comment
There was a problem hiding this comment.
Thanks, r=me once PR CI is green.
Contributor
|
@bors r=jieyouxu rollup |
Collaborator
bors
added
S-waiting-on-bors
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Dec 20, 2024
…eyouxu tests/codegen/asm: Remove uses of rustc_attrs and lang_items features by using minicore Similar to rust-lang#134385 (for tests/ui/asm) and rust-lang#134436 (for tests/assembly/asm), but for tests/codegen/asm. r? jieyouxu
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#134556 ([tiny] fix missing ns units in bootstrap's benchmark rendering) - rust-lang#134560 (mri: add track_caller to thread spawning methods for better backtraces) - rust-lang#134561 (Reduce the amount of explicit FatalError.raise()) - rust-lang#134562 (tests/codegen/asm: Remove uses of rustc_attrs and lang_items features by using minicore) - rust-lang#134567 (Remove some dead code around import library generation) - rust-lang#134570 (remove reference to dangling from slice::Iter) - rust-lang#134573 (unimplement `PointerLike` for trait objects) - rust-lang#134574 (next-solver: disable unnecessary hack) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 20, 2024
Rollup merge of rust-lang#134562 - taiki-e:codegen-asm-minicore, r=jieyouxu tests/codegen/asm: Remove uses of rustc_attrs and lang_items features by using minicore Similar to rust-lang#134385 (for tests/ui/asm) and rust-lang#134436 (for tests/assembly/asm), but for tests/codegen/asm. r? jieyouxu
jieyouxu
added
the
A-testsuite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to #134385 (for tests/ui/asm) and #134436 (for tests/assembly/asm), but for tests/codegen/asm.
r? jieyouxu