Add `read_buf` equivalents for positioned reads by niklasf · Pull Request #140459 · rust-lang/rust

niklasf · 2025-04-29T13:54:42Z

Adds the following items under the ~~read_buf (#78485)~~ read_buf_at (#140771) feature:

std::os::unix::fs::FileExt::read_buf_at
std::os::unix::fs::FileExt::read_buf_exact_at
std::os::windows::fs::FileExt::seek_read_buf

try-job: x86_64-msvc*
try-job: test-various*
try-job: dist-various*

rustbot · 2025-04-29T13:54:54Z

rustbot has assigned @tgross35.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

tgross35 · 2025-05-01T00:54:44Z

Have these changes been discussed with libs-api at all? Usually changes to unstable API need to be proposed at https://github.com/rust-lang/libs-team/ with the ACP issue template.

This needs some tests as well.

tgross35 · 2025-05-01T01:42:49Z

For the above,
@rustbot author

rustbot · 2025-05-01T01:42:54Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

Kivooeo · 2025-05-08T04:28:04Z

For consistency and clarity, could we include safety comments on each unsafe block? Even brief notes are helpful to understand the assumptions being made

niklasf · 2025-05-12T23:13:31Z

Thank you both.

Opened an APC that was accepted, but items to be added under a new feature instead of read_buf. Moved to read_buf_at with new tracking issue Tracking Issue for read_buf_at #140771.
Added safety comments also for FFI calls.
Added tests.

@rustbot ready

library/std/src/sys/fd/unix.rs

library/std/src/os/unix/fs.rs

library/std/src/sys/fd/unix.rs

tgross35 · 2025-05-28T22:38:03Z

@bors try

Add `read_buf` equivalents for positioned reads Adds the following items under the ~~`read_buf` (#78485)~~ `read_buf_at` (#140771) feature: - `std::os::unix::fs::FileExt::read_buf_at` - `std::os::unix::fs::FileExt::read_buf_exact_at` - `std::os::windows::fs::FileExt::seek_read_buf` try-job: x86_64-msvc-1 try-job: x86_64-msvc-2

tgross35

Thanks for the updates, two small nits then r=me

View changes since this review

library/std/src/sys/fd/unix.rs

Adds the following items under the `read_buf_at` feature: - `std::os::unix::fs::FileExt::read_buf_at` - `std::os::unix::fs::FileExt::read_buf_exact_at` - `std::os::windows::fs::FileExt::seek_read_buf`

niklasf · 2025-09-03T18:51:39Z

@rustbot ready

tgross35 · 2025-09-03T18:55:11Z

Going to rerun the try job just in case, but LGTM. Thanks for the updates

@bors2 try

Add `read_buf` equivalents for positioned reads try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`

rust-bors · 2025-09-03T21:28:59Z

☀️ Try build successful (CI)
Build commit: f0baf1c (f0baf1cd9fa552c3e2ab50b1610b11ce86350ef2, parent: fd75a9c32d643f39c8c61df770d2cff60b3fefd5)

tgross35 · 2025-09-03T21:34:10Z

@bors r+

bors · 2025-09-03T21:34:13Z

📌 Commit c914c47 has been approved by tgross35

It is now in the queue for this repository.

…oss35 Add `read_buf` equivalents for positioned reads Adds the following items under the ~~`read_buf` (rust-lang#78485)~~ `read_buf_at` (rust-lang#140771) feature: - `std::os::unix::fs::FileExt::read_buf_at` - `std::os::unix::fs::FileExt::read_buf_exact_at` - `std::os::windows::fs::FileExt::seek_read_buf` try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`

Rollup of 24 pull requests Successful merges: - #140459 (Add `read_buf` equivalents for positioned reads) - #143725 (core: add Peekable::next_if_map) - #145209 (Stabilize `path_add_extension`) - #145342 (fix drop scope for `super let` bindings within `if let`) - #145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - #145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const) - #145932 (Allow `inline(always)` with a target feature behind a unstable feature `target_feature_inline_always`.) - #145962 (Ensure we emit an allocator shim when only some crate types need one) - #145963 (Add LSX accelerated implementation for source file analysis) - #146054 (add `#[must_use]` to `array::repeat`) - #146090 (Derive `PartialEq` for `InvisibleOrigin`) - #146112 (don't uppercase error messages) - #146120 (Correct typo in `rustc_errors` comment) - #146124 (Test `rustc-dev` in `distcheck`) - #146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - #146131 (rustdoc-search: add test case for indexing every item type) - #146134 (llvm: nvptx: Layout update to match LLVM) - #146136 (docs(std): add missing closing code block fences in doc comments) - #146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - #146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - #146150 (fix(rustdoc): match rustc `--emit` precedence ) - #146155 (Make bootstrap self test parallel) - #146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths) - #146172 (triagebot: configure some pings when certain attributes are used) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of #140459 - niklasf:feature/read-buf-at, r=tgross35 Add `read_buf` equivalents for positioned reads Adds the following items under the ~~`read_buf` (#78485)~~ `read_buf_at` (#140771) feature: - `std::os::unix::fs::FileExt::read_buf_at` - `std::os::unix::fs::FileExt::read_buf_exact_at` - `std::os::windows::fs::FileExt::seek_read_buf` try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`

Rollup of 24 pull requests Successful merges: - rust-lang/rust#140459 (Add `read_buf` equivalents for positioned reads) - rust-lang/rust#143725 (core: add Peekable::next_if_map) - rust-lang/rust#145209 (Stabilize `path_add_extension`) - rust-lang/rust#145342 (fix drop scope for `super let` bindings within `if let`) - rust-lang/rust#145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - rust-lang/rust#145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const) - rust-lang/rust#145932 (Allow `inline(always)` with a target feature behind a unstable feature `target_feature_inline_always`.) - rust-lang/rust#145962 (Ensure we emit an allocator shim when only some crate types need one) - rust-lang/rust#145963 (Add LSX accelerated implementation for source file analysis) - rust-lang/rust#146054 (add `#[must_use]` to `array::repeat`) - rust-lang/rust#146090 (Derive `PartialEq` for `InvisibleOrigin`) - rust-lang/rust#146112 (don't uppercase error messages) - rust-lang/rust#146120 (Correct typo in `rustc_errors` comment) - rust-lang/rust#146124 (Test `rustc-dev` in `distcheck`) - rust-lang/rust#146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - rust-lang/rust#146131 (rustdoc-search: add test case for indexing every item type) - rust-lang/rust#146134 (llvm: nvptx: Layout update to match LLVM) - rust-lang/rust#146136 (docs(std): add missing closing code block fences in doc comments) - rust-lang/rust#146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - rust-lang/rust#146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - rust-lang/rust#146150 (fix(rustdoc): match rustc `--emit` precedence ) - rust-lang/rust#146155 (Make bootstrap self test parallel) - rust-lang/rust#146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths) - rust-lang/rust#146172 (triagebot: configure some pings when certain attributes are used) r? `@ghost` `@rustbot` modify labels: rollup

…oss35 Add `read_buf` equivalents for positioned reads Adds the following items under the ~~`read_buf` (rust-lang#78485)~~ `read_buf_at` (rust-lang#140771) feature: - `std::os::unix::fs::FileExt::read_buf_at` - `std::os::unix::fs::FileExt::read_buf_exact_at` - `std::os::windows::fs::FileExt::seek_read_buf` try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`

Rollup of 24 pull requests Successful merges: - rust-lang#140459 (Add `read_buf` equivalents for positioned reads) - rust-lang#143725 (core: add Peekable::next_if_map) - rust-lang#145209 (Stabilize `path_add_extension`) - rust-lang#145342 (fix drop scope for `super let` bindings within `if let`) - rust-lang#145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - rust-lang#145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const) - rust-lang#145932 (Allow `inline(always)` with a target feature behind a unstable feature `target_feature_inline_always`.) - rust-lang#145962 (Ensure we emit an allocator shim when only some crate types need one) - rust-lang#145963 (Add LSX accelerated implementation for source file analysis) - rust-lang#146054 (add `#[must_use]` to `array::repeat`) - rust-lang#146090 (Derive `PartialEq` for `InvisibleOrigin`) - rust-lang#146112 (don't uppercase error messages) - rust-lang#146120 (Correct typo in `rustc_errors` comment) - rust-lang#146124 (Test `rustc-dev` in `distcheck`) - rust-lang#146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - rust-lang#146131 (rustdoc-search: add test case for indexing every item type) - rust-lang#146134 (llvm: nvptx: Layout update to match LLVM) - rust-lang#146136 (docs(std): add missing closing code block fences in doc comments) - rust-lang#146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - rust-lang#146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - rust-lang#146150 (fix(rustdoc): match rustc `--emit` precedence ) - rust-lang#146155 (Make bootstrap self test parallel) - rust-lang#146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths) - rust-lang#146172 (triagebot: configure some pings when certain attributes are used) r? `@ghost` `@rustbot` modify labels: rollup

Rollup of 24 pull requests Successful merges: - rust-lang/rust#140459 (Add `read_buf` equivalents for positioned reads) - rust-lang/rust#143725 (core: add Peekable::next_if_map) - rust-lang/rust#145209 (Stabilize `path_add_extension`) - rust-lang/rust#145342 (fix drop scope for `super let` bindings within `if let`) - rust-lang/rust#145750 (raw_vec.rs: Remove superfluous fn alloc_guard) - rust-lang/rust#145827 (On unused binding or binding not present in all patterns, suggest potential typo of unit struct/variant or const) - rust-lang/rust#145932 (Allow `inline(always)` with a target feature behind a unstable feature `target_feature_inline_always`.) - rust-lang/rust#145962 (Ensure we emit an allocator shim when only some crate types need one) - rust-lang/rust#145963 (Add LSX accelerated implementation for source file analysis) - rust-lang/rust#146054 (add `#[must_use]` to `array::repeat`) - rust-lang/rust#146090 (Derive `PartialEq` for `InvisibleOrigin`) - rust-lang/rust#146112 (don't uppercase error messages) - rust-lang/rust#146120 (Correct typo in `rustc_errors` comment) - rust-lang/rust#146124 (Test `rustc-dev` in `distcheck`) - rust-lang/rust#146127 (Rename `ToolRustc` to `ToolRustcPrivate`) - rust-lang/rust#146131 (rustdoc-search: add test case for indexing every item type) - rust-lang/rust#146134 (llvm: nvptx: Layout update to match LLVM) - rust-lang/rust#146136 (docs(std): add missing closing code block fences in doc comments) - rust-lang/rust#146137 (Disallow frontmatter in `--cfg` and `--check-cfg` arguments) - rust-lang/rust#146140 (compiletest: cygwin follows windows in using PATH for dynamic libraries) - rust-lang/rust#146150 (fix(rustdoc): match rustc `--emit` precedence ) - rust-lang/rust#146155 (Make bootstrap self test parallel) - rust-lang/rust#146161 ([rustdoc] Uncomment code to add scraped rustdoc examples in loaded paths) - rust-lang/rust#146172 (triagebot: configure some pings when certain attributes are used) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned tgross35 Apr 29, 2025

rustbot added O-unix Operating system: Unix-like O-windows Operating system: Windows S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 29, 2025

This comment has been minimized.

Sign in to view

niklasf closed this Apr 29, 2025

niklasf force-pushed the feature/read-buf-at branch from 74e016c to 2ccb45f Compare April 29, 2025 14:07

niklasf reopened this Apr 29, 2025

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2025

niklasf mentioned this pull request May 7, 2025

Tracking Issue for read_buf_at #140771

Open

4 tasks

niklasf force-pushed the feature/read-buf-at branch from 2ccb45f to 09ac65a Compare May 12, 2025 21:45

This comment has been minimized.

Sign in to view

niklasf force-pushed the feature/read-buf-at branch from 09ac65a to a22d2b4 Compare May 12, 2025 22:06

This comment has been minimized.

Sign in to view

niklasf force-pushed the feature/read-buf-at branch from a22d2b4 to 59cb58e Compare May 12, 2025 22:30

This comment has been minimized.

Sign in to view

niklasf force-pushed the feature/read-buf-at branch from 59cb58e to 85e1da1 Compare May 12, 2025 22:41

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 12, 2025

tgross35 reviewed May 28, 2025

View reviewed changes

library/std/src/sys/fd/unix.rs Outdated Show resolved Hide resolved

library/std/src/os/unix/fs.rs Show resolved Hide resolved

library/std/src/sys/fd/unix.rs Outdated Show resolved Hide resolved

tgross35 requested changes Sep 3, 2025

View reviewed changes

library/std/src/sys/fd/unix.rs Show resolved Hide resolved

library/std/src/sys/fd/unix.rs Show resolved Hide resolved

library/std/src/sys/fd/unix.rs Show resolved Hide resolved

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2025

niklasf force-pushed the feature/read-buf-at branch from bf491a1 to 60c69e1 Compare September 3, 2025 18:29

Add read_buf equivalents for positioned reads

c914c47

Adds the following items under the `read_buf_at` feature: - `std::os::unix::fs::FileExt::read_buf_at` - `std::os::unix::fs::FileExt::read_buf_exact_at` - `std::os::windows::fs::FileExt::seek_read_buf`

niklasf force-pushed the feature/read-buf-at branch from 60c69e1 to c914c47 Compare September 3, 2025 18:43

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2025

tgross35 approved these changes Sep 3, 2025

View reviewed changes

rust-bors bot added a commit that referenced this pull request Sep 3, 2025

Auto merge of #140459 - niklasf:feature/read-buf-at, r=<try>

f0baf1c

Add `read_buf` equivalents for positioned reads try-job: `x86_64-msvc*` try-job: `test-various*` try-job: `dist-various*`

This comment has been minimized.

Sign in to view

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2025

Zalathar mentioned this pull request Sep 4, 2025

Rollup of 24 pull requests #146185

Merged

bors merged commit f073f64 into rust-lang:master Sep 4, 2025
11 checks passed

rustbot added this to the 1.91.0 milestone Sep 4, 2025

Uh oh!

Conversation

niklasf commented Apr 29, 2025 • edited by tgross35 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Apr 29, 2025

Uh oh!

This comment has been minimized.

tgross35 commented May 1, 2025

Uh oh!

tgross35 commented May 1, 2025

Uh oh!

rustbot commented May 1, 2025

Uh oh!

Kivooeo commented May 8, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

niklasf commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tgross35 commented May 28, 2025

Uh oh!

tgross35 left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

niklasf commented Sep 3, 2025

Uh oh!

tgross35 commented Sep 3, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Sep 3, 2025

Uh oh!

tgross35 commented Sep 3, 2025

Uh oh!

bors commented Sep 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

niklasf commented Apr 29, 2025 •

edited by tgross35

Loading

niklasf commented May 12, 2025 •

edited

Loading

tgross35 left a comment •

edited by rustbot

Loading