Skip to content

try enabling linker-messages by default again #149937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jyn514 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

try enabling linker-messages by default again #149937

jyn514 wants to merge 4 commits into from

Conversation

@jyn514
Copy link
Member

@jyn514 jyn514 commented Dec 13, 2025 •
edited
Loading

  • Split out linker-info from linker-messages
  • Make linker-messages warn-by-default; keep linker-info deny-by-default

Helps with #136096.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@saethlin
Copy link
Member

saethlin commented Dec 13, 2025

@bors try

@rust-bors

This comment has been minimized.

Sign in to view
rust-bors bot added a commit that referenced this pull request Dec 13, 2025
@rust-bors
Auto merge of #149937 - jyn514:linker-info, r=<try>
58b1b3c 
try enabling `linker-messages` by default again
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-bors
Copy link
Contributor

rust-bors bot commented Dec 13, 2025

☀️ Try build successful (CI)
Build commit: 58b1b3c (58b1b3c5342a414c161338871f8004258ccef2a7, parent: eb171a227f9e5de5d376b6edb56b174bc8235fb3)

@saethlin
Copy link
Member

saethlin commented Dec 13, 2025

@craterbot build-only

@craterbot
Copy link
Collaborator

craterbot commented Dec 13, 2025

🚨 Error: failed to parse the command

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@saethlin
Copy link
Member

saethlin commented Dec 13, 2025

@craterbot run mode=build-only

@craterbot
Copy link
Collaborator

craterbot commented Dec 13, 2025

👌 Experiment pr-149937 created and queued.
🤖 Automatically detected try build 58b1b3c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 13, 2025
@rustbot rustbot added the A-run-make Area: port run-make Makefiles to rmake.rs label Dec 13, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@jyn514 jyn514 mentioned this pull request Dec 14, 2025
Merged
@rust-log-analyzer

This comment has been minimized.

Sign in to view
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#149969 - jyn514:ibt, r=jieyouxu
efdd61d 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang#149937.

cc `@jieyouxu` `@Oneirical`
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#149969 - jyn514:ibt, r=jieyouxu
1b7cc44 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang#149937.

cc ``@jieyouxu`` ``@Oneirical``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 14, 2025
@matthiaskrgr
Rollup merge of rust-lang#149969 - jyn514:ibt, r=jieyouxu
98f8736 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang#149937.

cc ```@jieyouxu``` ```@Oneirical```
rust-timer added a commit that referenced this pull request Dec 15, 2025
@rust-timer
Unrolled build for #149969
d399792 
Rollup merge of #149969 - jyn514:ibt, r=jieyouxu

don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of #149937.

cc ```@jieyouxu``` ```@Oneirical```
@bors
Copy link
Collaborator

bors commented Dec 15, 2025

☔ The latest upstream changes (presumably #149999) made this pull request unmergeable. Please resolve the merge conflicts.

github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Dec 18, 2025
@matthiaskrgr
Rollup merge of #149969 - jyn514:ibt, r=jieyouxu
a0921cf 
don't use no_main and no_core to test IBT

The previous test was quite fragile and depended on a bunch of internal features. Simplify it.

Split out of rust-lang/rust#149937.

cc ```@jieyouxu``` ```@Oneirical```
@craterbot
Copy link
Collaborator

craterbot commented Dec 25, 2025

🚧 Experiment pr-149937 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

craterbot commented Dec 27, 2025

🎉 Experiment pr-149937 is completed!
📊 24 regressed and 5 fixed (758860 total)
📊 2582 spurious results on the retry-regressed-list.txt, consider a retry1 if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

  1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-149937/retry-regressed-list.txt ↩

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Dec 27, 2025
@jyn514
Copy link
Member Author

jyn514 commented Dec 27, 2025

lots of things that look like rust-lld: /opt/rustwide/target/debug/deps/libclp_src-3fcc87e3676feea0.rlib: archive member 'd49e9b1215e2db8a-Clp_C_Interface.o' is neither ET_REL nor LLVM bitcode, from many different crates. That might be crate specific or it might be a toolchain bug, I’ll investigate in a bit.

There was also someone using intrinsics::type_name() wrong, which caused an ICE, that seems like a real problem but not related to this PR.

@jyn514
Copy link
Member Author

jyn514 commented Dec 27, 2025

I kinda want to do another run but with -C self-contained-linker=no this time.

@mati865
Copy link
Member

mati865 commented Dec 27, 2025

Most (if not all, I didn't check them all) failures involve static C-based libraries. Moreover, many of them use convoluted ways to build the libraries (I didn't bother checking them), are not quite correct, or even use prebbuild objects.
https://github.com/nikolalukovic/puki/tree/8857ac5997ee3e02f386573185f1448766e771d2 is one that I don't see why it'd fail.

@jyn514
Copy link
Member Author

jyn514 commented Jan 31, 2026

I think this is few enough failures I'm comfortable making this warn-by-default again, at least for a couple nightlies.

jyn514 and others added 2 commits January 31, 2026 15:39
@jyn514
Split out linker-info from linker-messages
8ad1c88 
- Hide common linker output behind `linker-info`
- Add tests
- Account for different capitalization on windows-gnu when removing
  "warning" prefix
- Add some more comments
- Add macOS deployment-target test
- Ignore linker warnings from trying to statically link glibc

  I don't know what's going on in `nofile-limit.rs` but I want no part
  of it.
@jyn514
Set linker-messages to warn-by-default
dc1d3bc
@jyn514 jyn514 marked this pull request as ready for review January 31, 2026 20:45
@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2026

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rustbot
Copy link
Collaborator

rustbot commented Jan 31, 2026

r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@jyn514
Copy link
Member Author

jyn514 commented Jan 31, 2026

r? @mati865

@rustbot rustbot assigned mati865 and unassigned BoxyUwU Jan 31, 2026
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jan 31, 2026

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
REPOSITORY                                   TAG       IMAGE ID       CREATED      SIZE
ghcr.io/dependabot/dependabot-updater-core   latest    bcec0b4e062b   5 days ago   783MB
=> Removing docker images...
Deleted Images:
untagged: ghcr.io/dependabot/dependabot-updater-core:latest
untagged: ghcr.io/dependabot/dependabot-updater-core@sha256:b662be51f7b8ef7e2c8464428f14e49cb79c36aa9afb7ecb9221dfe0f507050c
deleted: sha256:bcec0b4e062b5ffe11cc1c2729558c0cd96621c0271ab5e97ff3a56e0c25045a
deleted: sha256:64e147d5e54d9be8b8aa322e511cda02296eda4b8b8d063c6a314833aca50e29
deleted: sha256:5cba409bb463f4e7fa1a19f695450170422582c1bc7c0e934d893b4e5f558bc6
deleted: sha256:cddc6ebd344b0111eaab170ead1dfda24acdfe865ed8a12599a34d338fa8e28b
deleted: sha256:2412c3f334d79134573cd45e657fb6cc0abd75bef3881458b0d498d936545c8d
---
tests/ui/double_parens.rs ... ok
tests/ui/drop_non_drop.rs ... ok
tests/ui/duplicate_underscore_argument.rs ... ok
tests/ui/duplicated_attributes.rs ... ok
tests/ui/duration_suboptimal_units_days_weeks.rs ... ok
tests/ui/duration_suboptimal_units.rs ... ok
tests/ui/duration_subsec.rs ... ok
tests/ui/double_parens.fixed ... ok
tests/ui/duration_suboptimal_units_days_weeks.fixed ... ok
tests/ui/duration_suboptimal_units.fixed ... ok
tests/ui/duration_subsec.fixed ... ok
tests/ui/elidable_lifetime_names.rs ... ok
tests/ui/eager_transmute.rs ... ok
tests/ui/else_if_without_else.rs ... ok
tests/ui/empty_docs.rs ... ok
---
...............................................    (147/147)

======== tests/rustdoc-gui/globals.goml ========

[ERROR] line 14: Error: The window properties still all match: for command `wait-for-window-property-false: {"searchIndex": null}`
    at <file:///checkout/obj/build/x86_64-unknown-linux-gnu/test/rustdoc-gui/doc/test_docs/index.html?search=Foo>

======== tests/rustdoc-gui/search-result-display.goml ========

[WARNING] line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead?

@zacknewman
Copy link

zacknewman commented Feb 1, 2026 •
edited
Loading

@jyn514, there is still an issue with macOS; so I'm not sure this should be enabled yet. See #151970.

@jyn514
Copy link
Member Author

jyn514 commented Feb 2, 2026

@zacknewman that warning has been moved into the new linker-info lint, which is allow-by-default.

@zacknewman
Copy link

zacknewman commented Feb 2, 2026 •
edited
Loading

@zacknewman that warning has been moved into the new linker-info lint, which is allow-by-default.

Has that change made it to nightly? Yesterday I tried using the nightly compiler, and it still erred.

rustc -Whelp using nightly doesn't contain linker-info, so the error occurring on nightly is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mati865 mati865

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@jyn514 @rust-log-analyzer @saethlin @craterbot @bors @mati865 @rustbot @zacknewman @BoxyUwU