-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
Move std_detect tests into a separate crate #150813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
|
r? @clubby789 rustbot has assigned @clubby789. Use |
This comment has been minimized.
This comment has been minimized.
9da3959 to
2aef964
Compare
|
Bootstrap changes look fine to me, so r? libs |
This comment has been minimized.
This comment has been minimized.
|
r? libs |
2aef964 to
bc1d73e
Compare
This comment has been minimized.
This comment has been minimized.
1013779 to
c18ed7b
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me for the libs parts, but I'd like somebody more familiar with bootstrap to make sure there isn't anything missing.
r? bootstrap
|
To make sure things still build on some of the targets here @bors try jobs=test-various |
This comment has been minimized.
This comment has been minimized.
Move std_detect tests into a separate crate try-job: test-various
|
Bootstrap changes look straightforward, and I don't see any special handling for coretests/alloctests that has been missed for std_detect_tests, so r=me on that front. r? tgross35 |
|
Yes @bors r- |
|
Commit bc56f5d has been unapproved. |
|
@matthiaskrgr which rollup did this PR fail in? #151609 failed on another PR. #151614 passed CI, but got closed before bors tested it. |
|
it was a local build |
|
What configuration? |
|
@bors r+ rollup=never May as well find out |
This comment has been minimized.
This comment has been minimized.
Move std_detect tests into a separate crate Same rationale as #136642.
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 4c08d8b failed: CI. Failed job:
|
|
@rustbot author |
bc56f5d to
ca8d372
Compare
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
@bors try jobs=x86_64-gnu-llvm-21-3 |
This comment has been minimized.
This comment has been minimized.
Move std_detect tests into a separate crate try-job: x86_64-gnu-llvm-21-3
|
💔 Test for 3d09ab0 failed: CI. Failed job:
|
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Same rationale as #136642.