Skip to content

Conversation

@petrochenkov
Copy link
Contributor

Visit RPITITs and report private_interfaces, private_bounds and exported_private_dependencies in them (these are regular, non-deprecation lints).
New hard errors are not reported, #146470 is for hard errors.
So this PR doesn't contain any breakage or language changes.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 15, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jan 15, 2026
@rustbot
Copy link
Collaborator

rustbot commented Jan 15, 2026

r? @eholk

rustbot has assigned @eholk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Jan 29, 2026

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@petrochenkov
Copy link
Contributor Author

ping @eholk, it's been 2 weeks.

@eholk
Copy link
Contributor

eholk commented Jan 29, 2026

Sorry about my delay here. Looking now!

@eholk
Copy link
Contributor

eholk commented Jan 29, 2026

@bors r+

@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 29, 2026

📌 Commit 7c9d149 has been approved by eholk

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 29, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 30, 2026
@rust-bors
Copy link
Contributor

rust-bors bot commented Jan 30, 2026

☀️ Test successful - CI
Approved by: eholk
Duration: 3h 36m 5s
Pushing ef2657c to main...

@rust-bors rust-bors bot merged commit ef2657c into rust-lang:main Jan 30, 2026
12 checks passed
@rustbot rustbot added this to the 1.95.0 milestone Jan 30, 2026
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 35a31ba (parent) -> ef2657c (this PR)

Test differences

Show 8 test diffs

Stage 1

  • [ui] tests/ui/privacy/missing-mir-priv-bounds-2.rs: [missing] -> pass (J0)
  • [ui] tests/ui/privacy/missing-mir-priv-bounds-3.rs: [missing] -> pass (J0)
  • [ui] tests/ui/privacy/missing-mir-priv-bounds.rs: [missing] -> pass (J0)

Stage 2

  • [ui] tests/ui/privacy/missing-mir-priv-bounds-2.rs: [missing] -> pass (J1)
  • [ui] tests/ui/privacy/missing-mir-priv-bounds-3.rs: [missing] -> pass (J1)
  • [ui] tests/ui/privacy/missing-mir-priv-bounds.rs: [missing] -> pass (J1)

Additionally, 2 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard ef2657cbaf6885b71e5ffd277ffe72a2616c0a7c --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. aarch64-apple: 8964.1s -> 12499.0s (+39.4%)
  2. x86_64-gnu-gcc: 3407.2s -> 4154.3s (+21.9%)
  3. dist-aarch64-apple: 6754.1s -> 8111.3s (+20.1%)
  4. pr-check-1: 1611.1s -> 1879.3s (+16.6%)
  5. x86_64-gnu-miri: 4172.3s -> 4826.5s (+15.7%)
  6. x86_64-rust-for-linux: 2704.6s -> 3082.4s (+14.0%)
  7. i686-gnu-2: 5251.1s -> 5965.8s (+13.6%)
  8. test-various: 6582.7s -> 7468.7s (+13.5%)
  9. x86_64-gnu-tools: 3304.8s -> 3731.5s (+12.9%)
  10. dist-x86_64-apple: 9031.0s -> 7986.5s (-11.6%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (ef2657c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
1.2% [0.6%, 1.8%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [-2.0%, 1.8%] 3

Cycles

Results (primary -2.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.0% [-2.0%, -2.0%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.0% [-2.0%, -2.0%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 476.214s -> 545.612s (14.57%)
Artifact size: 397.88 MiB -> 397.86 MiB (-0.00%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants