rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination#153035
Open
Gelbpunkt wants to merge 1 commit intorust-lang:mainfrom
Open
rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination#153035Gelbpunkt wants to merge 1 commit intorust-lang:mainfrom
Gelbpunkt wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
…t_abi for ABI determination Currently on PowerPC64 targets, llvm_abiname and target_abi will be the same unless we're on AIX. Since llvm_abiname is what we pass on to LLVM, it is preferable to use the value of that to determine the calling convention rather than target_abi. All PowerPC64 targets set both llvm_abiname and target_abi to the respective ELF ABIs, with the exception of AIX. This is a non-functional change.
Gelbpunkt
force-pushed
the
ppc64-callconv-llvm-abiname
branch
from
a3237e2 to
d501f96
Compare
Member
|
LGTM, thanks! r=me when CI is green. @bors delegate+ |
Contributor
|
✌️ @Gelbpunkt, you can now approve this pull request! If @RalfJung told you to " |
Contributor
Author
|
CI is green without changes, so: @bors r=RalfJung |
Contributor
rust-bors
bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 25, 2026
…ame, r=RalfJung rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination Currently on PowerPC64 targets, `llvm_abiname` and `target_abi` will be the same unless we're on AIX. Since `llvm_abiname` is what we pass on to LLVM, it is preferable to use the value of that to determine the calling convention rather than `target_abi`. All PowerPC64 targets set both `llvm_abiname` and `target_abi` to the respective ELF ABIs, with the exception of AIX. This is a non-functional change. Noticed this in the follow-up discussion from rust-lang#150468 and also requested by @RalfJung [here](rust-lang#150468 (comment)). r? @RalfJung
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 25, 2026
…ame, r=RalfJung rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination Currently on PowerPC64 targets, `llvm_abiname` and `target_abi` will be the same unless we're on AIX. Since `llvm_abiname` is what we pass on to LLVM, it is preferable to use the value of that to determine the calling convention rather than `target_abi`. All PowerPC64 targets set both `llvm_abiname` and `target_abi` to the respective ELF ABIs, with the exception of AIX. This is a non-functional change. Noticed this in the follow-up discussion from rust-lang#150468 and also requested by @RalfJung [here](rust-lang#150468 (comment)). r? @RalfJung
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 25, 2026
…ame, r=RalfJung rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination Currently on PowerPC64 targets, `llvm_abiname` and `target_abi` will be the same unless we're on AIX. Since `llvm_abiname` is what we pass on to LLVM, it is preferable to use the value of that to determine the calling convention rather than `target_abi`. All PowerPC64 targets set both `llvm_abiname` and `target_abi` to the respective ELF ABIs, with the exception of AIX. This is a non-functional change. Noticed this in the follow-up discussion from rust-lang#150468 and also requested by @RalfJung [here](rust-lang#150468 (comment)). r? @RalfJung
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 25, 2026
…ame, r=RalfJung rustc_target: callconv: powerpc64: Use llvm_abiname rather than target_abi for ABI determination Currently on PowerPC64 targets, `llvm_abiname` and `target_abi` will be the same unless we're on AIX. Since `llvm_abiname` is what we pass on to LLVM, it is preferable to use the value of that to determine the calling convention rather than `target_abi`. All PowerPC64 targets set both `llvm_abiname` and `target_abi` to the respective ELF ABIs, with the exception of AIX. This is a non-functional change. Noticed this in the follow-up discussion from rust-lang#150468 and also requested by @RalfJung [here](rust-lang#150468 (comment)). r? @RalfJung
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently on PowerPC64 targets,
llvm_abinameandtarget_abiwill be the same unless we're on AIX. Sincellvm_abinameis what we pass on to LLVM, it is preferable to use the value of that to determine the calling convention rather thantarget_abi.All PowerPC64 targets set both
llvm_abinameandtarget_abito the respective ELF ABIs, with the exception of AIX. This is a non-functional change.Noticed this in the follow-up discussion from #150468 and also requested by @RalfJung here.
r? @RalfJung