Merged
Conversation
Previously, they disagreed about what types were primitives. This also fixes a bug where rustdoc would mark any type with a reference as a primitive.
With this the concerns expressed in rust-lang#83800 should be addressed.
rustdoc: Implement `is_primitive` in terms of `primitive_type()` Previously, they disagreed about what types were primitives. r? `@GuillaumeGomez`
…o157 Use an SVG image for clipboard instead of unicode character Linked to rust-lang/docs.rs#1394. cc `@jsha` r? `@Nemo157`
…ber, r=jsha Fix source code line number display and make it clickable again Fixes rust-lang#85119. I used the same logic we're using for other codeblocks: putting the line number `<span>`s into the `example-wrap` directly and then add `display: inline-flex` on `example-wrap`. r? `@jsha`
…k-Simulacrum Adjust target search algorithm for rustlib path With this the concerns expressed in rust-lang#83800 should be addressed. r? `@Mark-Simulacrum`
Member
Author
|
@bors: r+ p=4 rollup=never |
Collaborator
|
📌 Commit 6ec1de7 has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
Collaborator
|
☀️ Test successful - checks-actions |
This was referenced May 10, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Successful merges:
is_primitivein terms ofprimitive_type()#84465 (rustdoc: Implementis_primitivein terms ofprimitive_type())Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup