Make Box drop through Drop trait#93105
Closed
beepster4096 wants to merge 1 commit intorust-lang:masterfrom
Closed
Conversation
Contributor
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
763eba2 to
6059879
Compare
Collaborator
|
The job Click to see the possible cause of the failure (guessed by this bot) |
Contributor
Author
|
Alright good, now that CI is failing in the way it should, all we have to do is wait for #93028 to merge. |
Member
|
I suspect this will run into problems with ensuring that the memory is indeed freed in case of incomplete initialization as part of the Would be a good idea to verify there are tests for these behaviours and if not – to implement some. |
Contributor
Author
|
Actually, this is still going to need some compiler magic for dropping T because of some of Box's other magic. |
Contributor
Author
|
Honestly, don't think this is that useful because of that. Not gonna bother finishing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes Box drop through its implementation of the Drop trait, instead of by being special-cased in the compiler.
Blocked on #93028