Repository navigation
Preserve SFTP state when nonblocking shutdown would block - #370
Merged
yodaldevoid merged 1 commit intoOct 29, 2026
Merged
Conversation
Collaborator
|
Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sftp::shutdownremoves its inner state before calling libssh2. When nonblocking shutdown returnsEAGAIN, the next call returnsBAD_USEand the native resource can no longer be cleaned up through the wrapper.Keep the uniquely held inner state until the native shutdown finishes.
EAGAINpreserves both the retry path and the existing blocking destructor; completed shutdown still disables cleanup, and open files still prevent shutdown. Fixes #368.The regression uses a loopback TCP proxy that pauses SSH server replies, so two successive shutdown attempts must return
EAGAIN. It then releases the replies, completes shutdown, checks repeated shutdown returnsBAD_USE, and opens another SFTP channel. A second test covers the open-file guard.Validation with a local OpenSSH fixture:
BAD_USEon the second attempt) and passes with the fix.