Use netlink-packet-route 0.29.0

[cathay4t]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @cathay4t, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on upgrading the netlink-packet-route crate to its 0.29.0 version. This upgrade necessitated minor code adjustments to align with changes in the dependency, specifically enhancing type safety for bond interface ad_select configurations. Additionally, a small typo in a bridge port attribute was corrected.

Highlights

• Dependency Update: The netlink-packet-route dependency has been updated from version 0.28 to 0.29 in Cargo.toml.
• Type Safety Improvement: The ad_select function in src/link/bond.rs was updated to use the BondAdSelect enum, enhancing type safety for bond interface configurations.
• Typo Correction: A typo in the neigh_vlan_suppress attribute name was corrected within src/link/bridge_port.rs.

Changelog

• Cargo.toml
  • Updated netlink-packet-route dependency from 0.28 to 0.29.
• src/link/bond.rs
  • Imported BondAdSelect from netlink-packet-route::link.
  • Modified the ad_select function signature to accept BondAdSelect instead of u8.
• src/link/bridge_port.rs
  • Corrected a typo in InfoBridgePort::NeighVlanSupress to InfoBridgePort::NeighVlanSuppress.

Activity

• No human activity has been recorded on this pull request since its creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the netlink-packet-route dependency to version 0.29.0. The associated code changes are correct and include improvements like better type safety for the ad_select function and a typo fix. However, one of the changes introduces a breaking API change. Please see the specific comment for details on why this requires a crate version bump to follow semantic versioning.

[gemini-code-assist]

Changing the parameter ad_select from type u8 to BondAdSelect is a breaking API change. While this change is good because it improves type safety, it will break existing code that uses this function. To adhere to semantic versioning, a breaking change in a 0.x.y version requires a minor version bump (e.g., from 0.20.0 to 0.21.0). Please update the crate version in Cargo.toml as part of this PR.