IteratorRandom::sample: allow large "amount" #1695
Merged
+3
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepancheg
force-pushed
the
iter-sample
branch
2 times, most recently
from
eb80734 to
cf6ba84
Compare
Member
|
From a look at the |
stepancheg
force-pushed
the
iter-sample
branch
from
cf6ba84 to
fef6c7a
Compare
Contributor
Author
|
Yes, I think we should just avoid guessing capacity, because in many cases iterator should provide lower bound, and when it is not, we will do a few reallocations, not a big deal. I updated the PR. |
stepancheg
force-pushed
the
iter-sample
branch
from
fef6c7a to
e9de258
Compare
stepancheg
force-pushed
the
iter-sample
branch
from
e9de258 to
f5dc304
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When requested amount is large but, but iterator is small, avoid allocating too large vec.
Motivation
If there's wrapper of such API (e.g. remote API), and it has parameter "sample size", because it is external API, user may pass very large value there, and if a user does that, it is better not to crash.
Details
This change is no-op where iterator lower bound is equal to iterator size.
CHANGELOG.mdentry