Fix braille rendering termination and frame completion - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The braille renderer walked floating-point coordinates until exact endpoint equality, could hang on fractional or very large values, could round edge-adjacent points out of bounds, and overflowed while clipping finite maximum-magnitude crossings. CPU labels could be cleared by graph rendering, and completed frames had no uniquely placed flushed marker.
Behavior
Frame: Nmarker as the final frame output and flush it immediately.Tests
cargo fmt --checkcargo check --locked --all-targetscargo clippy --locked --all-targets -- -D warningscargo test --locked(75 passed)cargo bench --locked --no-runcargo +1.88.0 check --locked --all-targetsGRAINX_REFRESH_INTERVAL_MS=100: frames 1-5 strictly increased;qexited 0; no signals.Limits
The PTY evidence covers the debug binary on one macOS Apple Silicon host at the two requested terminal sizes. It demonstrates bounded completion and graceful quit, not performance or cross-platform behavior. The temporary PTY driver is intentionally not committed; concise build and run evidence is recorded under
demos/.