Replace try! with question mark operator#61
Open
yoshinorisano wants to merge 1 commit intoruuda:masterfrom
Open
Replace try! with question mark operator#61yoshinorisano wants to merge 1 commit intoruuda:masterfrom
yoshinorisano wants to merge 1 commit intoruuda:masterfrom
Conversation
Author
|
@ruuda |
|
It would be great if this got merged. I'm working on a no_std support for this library. While I don't expect my changes will ever get merged (I had to switch to nightly) having this accepted would make it easier for me to keep my fork in sync with future changes. |
|
@ruuda Can this be merged? |
|
Haven't checked the open PRs and I redid this myself in #83, along with some other things, would be nice to get them merged. I noticed there's this repo and an identical codeberg link to each other, I'm not sure who's the mirror of who, but they both seem inactive |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a lot of compiler warnings when building hound:
warning: use of deprecated macro `try`: use the `?` operator insteadSo I tried to fix that. Does this make sense to you?