Fix conversion to ros2, because of rosbags version change#13
Merged
EmanueleGiacomini merged 1 commit intorvp-group:mainfrom Feb 21, 2025
mehermvr:ros2_conversion
Merged
Fix conversion to ros2, because of rosbags version change#13EmanueleGiacomini merged 1 commit intorvp-group:mainfrom mehermvr:ros2_conversion
EmanueleGiacomini merged 1 commit intorvp-group:mainfrom
mehermvr:ros2_conversion
Conversation
Contributor
|
Thanks for spotting this issue 🥇 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to convert the data to ros2 throws an error seemingly because of rosbags version change from 0.9.x to 0.10.x. The change is pretty simple which I suggest here, or the alternative can be to just pin the version in
pyproject.toml.For example, running (with main commit b422314)
throws the error
I suggest two changes:
rosconvert.convert().