Add conservative identifier readability check - #74
Merged
Merged
Conversation
MrC8559
marked this pull request as ready for review
September 17, 2026 11:05
Owner
|
MrC8559, thank you for this. You took on a hard part of the issue and kept it practical. The rule is clear, and the tests make its limits easy to see. I appreciate the care you put into it. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the names/identifiers half of #61 with a deliberately conservative AST check.
chk/cfg;fp_sz;yas a vowel to reduce false positives such assync;CHECKSregistry.The heuristic intentionally prefers false negatives over false positives. It is not a dictionary, general English checker, or claim of standards conformance.
Tests
Added focused coverage for:
Validation
Final upstream
gaterun #201 passed completely on commite148ff86a39306789c14ce953549f01a947bf4bc:The gate includes the repository's audit, security, pytest/100%-coverage, Pyright, Ruff format/lint, Pylint, and complexity checks. Earlier CI feedback was used to remove regex, satisfy the repository's docstring/style rules, simplify the tokenizer below the complexity cap, and restore full coverage/format compliance.
Scope
This does not touch the Vale/prose half of #61.