fix(otp): handle conflicting issuer in otpauth URI query param#38
Merged
Conversation
When the OTP URI has an issuer in the path label (e.g., 'issuer:account') and a different issuer in the query parameter, totp-rs rejects it with an issuer mismatch error. Drop the issuer query parameter when the path already contains an issuer, since the path issuer takes precedence per the otpauth spec. Also improve error reporting by preserving the specific TotpUrlError cause instead of mapping to a generic message, and by showing the URL parse error when normalization fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the OTP URI has an issuer in the path label (e.g., 'issuer:account') and a different issuer in the query parameter, totp-rs rejects it with an issuer mismatch error. Drop the issuer query parameter when the path already contains an issuer, since the path issuer takes precedence per the otpauth spec.
Also improve error reporting by preserving the specific TotpUrlError cause instead of mapping to a generic message, and by showing the URL parse error when normalization fails.