Avoid false positive in production secret scan - #162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
client_secretassignments, PEM private keys, and Stripe-style live keysRoot cause
The public
@google/genaibrowser bundle contains the OAuth schema identifierclient_secret. Production smoke rejected that identifier alone even though no credential value was present. The local container smoke already required a value-shaped assignment.Validation
node --test scripts/test/smoke-production.test.mjs— 4 passedBASE_URL=https://fieldwork-gajikud3na-uw.a.run.app node scripts/smoke-production.mjs— all production checks passed, including served-asset secret scanninggit diff --check— passedNo asset, dependency, or genuine secret-detection rule was excluded.