Skip to content

Avoid false positive in production secret scan - #162

Merged
ryanbaumann merged 1 commit into
mainfrom
agent/fix-production-secret-scan
Jul 27, 2026
Merged

Avoid false positive in production secret scan#162
ryanbaumann merged 1 commit into
mainfrom
agent/fix-production-secret-scan

Conversation

@ryanbaumann

Copy link
Copy Markdown
Owner

What changed

  • makes production smoke distinguish an OAuth schema field name from an assigned client-secret value
  • preserves detection for value-shaped client_secret assignments, PEM private keys, and Stripe-style live keys
  • adds regression coverage for allowed schema text, a short fixture, and a denied long value

Root cause

The public @google/genai browser bundle contains the OAuth schema identifier client_secret. Production smoke rejected that identifier alone even though no credential value was present. The local container smoke already required a value-shaped assignment.

Validation

  • node --test scripts/test/smoke-production.test.mjs — 4 passed
  • BASE_URL=https://fieldwork-gajikud3na-uw.a.run.app node scripts/smoke-production.mjs — all production checks passed, including served-asset secret scanning
  • git diff --check — passed

No asset, dependency, or genuine secret-detection rule was excluded.

@ryanbaumann
ryanbaumann marked this pull request as ready for review July 27, 2026 20:50
@ryanbaumann
ryanbaumann merged commit e15a6ca into main Jul 27, 2026
11 checks passed
@ryanbaumann
ryanbaumann deleted the agent/fix-production-secret-scan branch July 27, 2026 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant