Skip to content

fix(live): Live-screen strap-log save carries the same extras as Settings and Test Centre #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryanbr merged 1 commit into from
Sep 23, 2026
Merged

fix(live): Live-screen strap-log save carries the same extras as Settings and Test Centre #2367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions Strand/Screens/LiveView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1252,6 +1252,7 @@ private struct ActiveWorkoutLive: View {
/// re-render only this card. Wrapped in the liquid frosted card style.
private struct LiveLogCard: View {
@EnvironmentObject private var live: LiveState
@EnvironmentObject private var model: AppModel
@AppStorage(CardAppearancePrefs.opacityKey) private var cardOpacityPercent = CardAppearancePrefs.defaultPercent
private var cardOpacity: Double { max(0, min(1, Double(cardOpacityPercent) / 100)) }

Expand Down Expand Up @@ -1318,8 +1319,14 @@ private struct LiveLogCard: View {
}

private func saveStrapLog() {
FileExport.exportText(live.exportableLogText(),
suggestedName: FileExport.timestampedName("noop-strap-log", ext: "txt"))
Task {
// Settings (#507) and Test Centre fetch these extras before exporting; without them this
// site wrote a same-named file silently missing the "Strap & data" + funnel sections, so
// which button someone pressed changed what a triager received.
let extra = await DebugDataDiagnostics.dynamicLines(repo: model.repo)
FileExport.exportText(live.exportableLogText(extraHeaderLines: extra),
suggestedName: FileExport.timestampedName("noop-strap-log", ext: "txt"))
}
}
}

Expand Down
Loading