feat(hal): Hardware Abstraction Layer for x86_64 #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a Hardware Abstraction Layer (HAL) that isolates x86_64-specific code behind traits, enabling future ARM64 support. New arch_impl module structure: - arch_impl/mod.rs: Module root with `current` alias for active arch - arch_impl/traits.rs: Architecture-agnostic traits (9 traits) - PrivilegeLevel, InterruptFrame, PageFlags, PageTableOps - PerCpuOps, SyscallFrame, TimerOps, InterruptController, CpuOps - arch_impl/x86_64/: x86_64 implementations - constants.rs: 76+ centralized x86_64 constants - cpu.rs: CpuOps (halt, interrupt control) - paging.rs: PageTableOps (CR3, CR4, TLB, page flags) - percpu.rs: PerCpuOps (GS-relative access, MSRs) - timer.rs: TimerOps (TSC, PIT calibration) Refactored modules to use HAL: - time/tsc.rs: Delegates TSC operations to HAL timer - per_cpu.rs: Uses HAL for GS base MSR operations - memory/paging.rs: Uses HAL for CR3/CR4/TLB operations - interrupts.rs: Uses HAL for TLB flush, halt, CR2 reading ~143 x86_64 crate usages remain outside HAL (context_switch.rs, gdt.rs, serial.rs, etc.) for future refactoring. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Implement all missing HAL trait implementations for x86_64: - X86PrivilegeLevel: Ring 0/3 abstraction implementing PrivilegeLevel trait - X86InterruptFrame: Wrapper around InterruptStackFrame implementing InterruptFrame trait - X86Pic: PIC controller implementing InterruptController trait - SyscallFrame: Add trait implementation with arg1-6() accessors All 9 HAL traits now have complete x86_64 implementations: - PrivilegeLevel, InterruptFrame, SyscallFrame, InterruptController - CpuOps, TimerOps, PageTableOps, PageFlags, PerCpuOps Validated: 138/138 boot stages pass. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
New Files:
kernel/src/arch_impl/x86_64/privilege.rs-X86PrivilegeLevel(Ring 0/3 abstraction)kernel/src/arch_impl/x86_64/interrupt_frame.rs-X86InterruptFrame(interrupt context wrapper)kernel/src/arch_impl/x86_64/pic.rs-X86Pic(PIC interrupt controller)Modified Files:
kernel/src/arch_impl/x86_64/mod.rs- Added module declarations and re-exportskernel/src/syscall/handler.rs- AddedSyscallFrametrait implementationHAL Traits Implemented
Test plan
cargo build --releasecompiles with zero errorscargo run -p xtask -- boot-stagespasses 138/138 stages🤖 Generated with Claude Code