Handle NaNs as page numbers from metadata service and add retries#21
Merged
ryanmccartney merged 4 commits intomainfrom May 9, 2026
Merged
Handle NaNs as page numbers from metadata service and add retries#21ryanmccartney merged 4 commits intomainfrom
ryanmccartney merged 4 commits intomainfrom
Conversation
ryanmccartney
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓Context
Occasionally, Open Library returns
NaNas a page number, this update improves handling of this case. This fixes part of the issue raised in #20.Sometime 503 responses are observed from the Google Books API. This appears to be intermittent. Makes metadata fetching more robust by introducing retries. Fixes main issue raised in #20.
📖 Description
Explicitly check page numbers are a number, if not default to 0.
Makes three retries with 500ms in between for failed metadata requests (only 5xx series errors). If all fail the final response is delivered.
Adds improved logging to isolate reason for metadata failures in future.
Changes in the codebase
Updates to book model, handle NaN and fix naming. Add
fetchRetryfunction and uses this for making metadata requests.