added features: implement graceful shutdown, tmux wrapper, and healthcheck#187
Open
tahmid-H wants to merge 1 commit into
Open
added features: implement graceful shutdown, tmux wrapper, and healthcheck#187tahmid-H wants to merge 1 commit into
tahmid-H wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Desription
Problems I encountered and tried to solve:
docker stopordocker compose downetc kills the container immediately without saving the world.Ctrl+Calso kills the container immediately without saving the world.These issues mainly stemmed from trying to update the server, since I had to manually save and exit before updating, instead of a simple
docker compose down && docker compose up -d.Changes Made
docker exec -it <container> tmux attach.Ctrl+Cin the console now just detaches the console instead of abruptly shutting down the server.docker stopordocker compose downnow injects theexitcommand into the tmux session before shutting down the container/game server.This works best with a liberal
stop_grace_period(I have it set to 1m but I'd say 2m just to be safe depending on the machine) if using docker compose, or adding-t -1todocker down/stop/restart.Let me know if you have any questions!