[codex] 移除公开商用子模块指针 - #20
Merged
Merged
Conversation
ronger-x
force-pushed
the
codex/remove-commercial-submodules
branch
from
May 7, 2026 05:16
4dce079 to
c3b6568
Compare
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
该 PR 旨在从公开主仓移除所有商用子模块的 submodule 配置与 gitlink 指针,避免公开 PR/提交列表暴露私有子模块的提交区间信息。
Changes:
- 删除根目录
.gitmodules,移除所有已声明的 submodule 配置 - 从 Git 索引中移除多个商用后端模块与前端 layer 的 gitlink(160000)条目
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| mortise-payment | 移除商用子模块 gitlink 指针 |
| mortise-ota | 移除商用子模块 gitlink 指针 |
| mortise-im | 移除商用子模块 gitlink 指针 |
| mortise-community | 移除商用子模块 gitlink 指针 |
| mortise-commerce | 移除商用子模块 gitlink 指针 |
| mortise-automation | 移除商用子模块 gitlink 指针 |
| mortise-aiot-gateway-mqtt | 移除商用子模块 gitlink 指针 |
| mortise-aiot | 移除商用子模块 gitlink 指针 |
| frontend/layers/community | 移除商用前端 layer 子模块 gitlink 指针 |
| frontend/layers/admin/ota | 移除商用前端 admin layer 子模块 gitlink 指针 |
| frontend/layers/admin/community | 移除商用前端 admin layer 子模块 gitlink 指针 |
| frontend/layers/admin/automation | 移除商用前端 admin layer 子模块 gitlink 指针 |
| frontend/layers/admin/aiot | 移除商用前端 admin layer 子模块 gitlink 指针 |
| .gitmodules | 删除 submodule 配置,避免公开仓继续跟踪私有模块指针 |
Comments suppressed due to low confidence (2)
.gitmodules:1
- 建议增加一个 CI/预提交校验来防回归(例如检测仓库中是否存在
.gitmodules或任何160000gitlink 条目),避免后续误操作再次把商用子模块指针提交到公开主仓。这样能把当前 PR 的安全边界固化为自动化规则。
.gitmodules:1 - 当前 PR 移除了商用子模块指针后,建议在面向开发者的入口文档(如 README/Quick Start/前端 README)补充:哪些模块为商用可选、公开仓在缺失这些目录时的预期构建方式(例如禁用的 profile/feature flag、跳过哪些构建步骤),以及推荐的私有分发/manifest/脚本获取方式的指引链接。否则新拉取公开仓的开发者容易在构建阶段遇到不可解释的缺模块问题。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
变更内容
.gitmodules。.gitmodules管理的商用子模块 gitlink,包括后端模块与前端 admin/layer 模块。背景
这些子模块均属于商用模块,不应该由公开
master直接跟踪 gitlink。否则后续公开 PR 只要更新这些指针,匿名访问者就可能在 PR 文件列表中看到私有子模块的提交区间信息。后续商用模块建议通过私有分发仓、私有 manifest 或部署脚本进行 clone/update 管理,不再把商用模块指针提交到公开主仓。
验证
git show --name-status --oneline --no-renames HEADgit ls-files -s | Select-String -Pattern '^160000'返回空.gitmodules已不存在规范链接: N/A